Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable phone field type #2700

Closed
thaisguigon opened this issue Nov 24, 2023 · 3 comments · Fixed by #5052
Closed

Enable phone field type #2700

thaisguigon opened this issue Nov 24, 2023 · 3 comments · Fixed by #5052
Assignees
@gitstart-twenty
Labels
scope: front Issues that are affecting the frontend side only size: hours type: feature

Comments

@thaisguigon
Copy link
Contributor

thaisguigon commented Nov 24, 2023 •
edited
Loading

Context

See #2494

For this issue:

  • Display a preview for the PHONE field type.
  • The preview by default displays: +1234-567-890.
  • Add SettingsObjectFieldPreview stories for the "PHONE" field type.

Figma

Image

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=15330%3A137231&mode=design&t=iJT6qeSb4rQhANlX-1
@thaisguigon thaisguigon mentioned this issue Nov 24, 2023
Closed
@thaisguigon thaisguigon self-assigned this Nov 24, 2023
@thaisguigon thaisguigon added scope: front Issues that are affecting the frontend side only type: feature labels Nov 24, 2023
@FelixMalfait
Copy link
Member

Let's make sure, as part of this issue, that the phone field type is shipped in prod / that people can add a custom phone field

@FelixMalfait FelixMalfait changed the title New object field - Step 2 - Add "Phone" field preview Enable phone field type Apr 15, 2024
@FelixMalfait
Copy link
Member

Most of the work has been done for this, it should be quick to enable it!

@gitstart-app GitStart App
Copy link
Contributor

gitstart-app bot commented Apr 15, 2024

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-2700

@gitstart-app gitstart-app bot mentioned this issue Apr 19, 2024
Merged
i-am-chitti pushed a commit to i-am-chitti/twenty that referenced this issue May 4, 2024
@gitstart-app @gitstart-twenty
@lucasbordeau @i-am-chitti
Enable phone field type (twentyhq#5052)
0983a20 
### Description

 Enable phone field type

### Refs

twentyhq#2700

### Demo


https://github.com/twentyhq/twenty/assets/140154534/e9810718-9916-4ad4-a080-4d718777de15

Fixes twentyhq#2700

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitstart-twenty gitstart-twenty

Labels
scope: front Issues that are affecting the frontend side only size: hours type: feature
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable phone field type twentyhq/twenty
4 participants
@thaisguigon @FelixMalfait @gitstart-twenty and others