Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back the ability to multi-note/task on index with the action bar #3106

Closed
Bonapara opened this issue Dec 21, 2023 · 5 comments · Fixed by #3137
Closed

Add back the ability to multi-note/task on index with the action bar #3106

Bonapara opened this issue Dec 21, 2023 · 5 comments · Fixed by #3137
Labels
good for experienced contributor scope: back+front Issues requiring full-stack knowledge size: hours size: minutes

Comments

@Bonapara
Copy link
Member

Bonapara commented Dec 21, 2023 •
edited

Current behavior

We can only delete records with the action bar on the index

Screenshot 2023-12-21 at 15 43 50

Desired behavior

The action bar should also allow to add a note/task on multiple records at once:

Screenshot 2023-12-21 at 15 46 12
@Bonapara Bonapara changed the title Add back the ability to multi-comment Add back the ability to multi-note/task on index with the action bar Dec 21, 2023
@i-am-chitti
Copy link
Contributor

Hey @Bonapara,
Is there any UI flow or wireframe document here? Like on click of "Task" what should open up or how user will add the task or notes?

Also, as issue title contains "Add back". Does it mean, it was present early and has been removed?

@Bonapara
Copy link
Member Author

Hi @i-am-chitti It should open the Note/task side panel of the record shows over the index:

image

Screen.Recording.2023-12-22.at.11.49.01.mov

@Kanav-Arora
Copy link
Contributor

Hi @i-am-chitti
Are you working on it?

@i-am-chitti
Copy link
Contributor

@Kanav-Arora, yes, I'm working on it.

i-am-chitti added a commit to i-am-chitti/twenty that referenced this issue Dec 22, 2023
@i-am-chitti
twentyhqGH-3106 fix activity drawer opener for selected rows hook
641297b
i-am-chitti added a commit to i-am-chitti/twenty that referenced this issue Dec 22, 2023
@i-am-chitti
twentyhqGH-3106 ability to multi note/task with action bar
94b8213
i-am-chitti added a commit to i-am-chitti/twenty that referenced this issue Dec 22, 2023
@i-am-chitti
twentyhqGH-3106 use snapshot to get selected row IDs
44cbf8b
i-am-chitti added a commit to i-am-chitti/twenty that referenced this issue Dec 22, 2023
@i-am-chitti
twentyhqGH-3106 format code & fix linting issues
fa1acac
@i-am-chitti i-am-chitti mentioned this issue Dec 22, 2023
Merged
@i-am-chitti
Copy link
Contributor

@Bonapara, have raised a PR here - #3137

lucasbordeau added a commit to i-am-chitti/twenty that referenced this issue Dec 26, 2023
@lucasbordeau
Merge branch 'main' into twentyhqGH-3106/update-action-bar
1e76610
lucasbordeau added a commit that referenced this issue Dec 26, 2023
@i-am-chitti @lucasbordeau
GH-3106 Ability to multi-note/task with action bar (#3137)
b650b1d 
* GH-3106 fix activity drawer opener for selected rows hook

* GH-3106 ability to multi note/task with action bar

* GH-3106 use snapshot to get selected row IDs

* GH-3106 format code & fix linting issues

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good for experienced contributor scope: back+front Issues requiring full-stack knowledge size: hours size: minutes
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-3106 Ability to multi-note/task with action bar i-am-chitti/twenty
3 participants
@Bonapara @i-am-chitti @Kanav-Arora