Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Index first column Stickiness on Mobile #4155

Closed
Bonapara opened this issue Feb 23, 2024 · 2 comments · Fixed by #4206
Closed

Adapt Index first column Stickiness on Mobile #4155

Bonapara opened this issue Feb 23, 2024 · 2 comments · Fixed by #4206
Assignees
@jeet1desai
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes

Comments

@Bonapara
Copy link
Member

Bonapara commented Feb 23, 2024 •
edited

Current behavior

The Index first column is Sticky when horizontally scrolling the columns

image

Desired Behavior

We want to adapt the first column stickiness on Mobile as it prevents good content readability. We want to keep only the companies Favicon and the checkboxes as we scroll to the right

image

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=23796-35984&mode=design&t=0qrJcy4ODeblizYh-11
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes labels Feb 23, 2024
@Bonapara Bonapara changed the title Remove Index first column Stickiness on Mobile Adapt Index first column Stickiness on Mobile Feb 23, 2024
@jeet1desai
Copy link
Contributor

Hey @Bonapara can you please assign this to me

@Bonapara
Copy link
Member Author

Done, thanks @jeet1desai!

jeet1desai added a commit to jeet1desai/twenty that referenced this issue Feb 27, 2024
@jeet1desai
twentyhq#4155 fixed first column stickiness on mobile
8796d65
@jeet1desai jeet1desai mentioned this issue Feb 27, 2024
Merged
charlesBochet pushed a commit that referenced this issue Mar 4, 2024
@jeet1desai @thaisguigon
Fixed index column stickiness mobile (#4206)
8c0ec33 
* #4155 fixed first column stickiness on mobile

* fixed eslint error

* resolved checkbox background

* refactor: remove RecordTableFirstColumnScrollEffect

* fix: resolved comment in PR

* #4123 CurrencyFieldInput design is ready

* Revert "#4123 CurrencyFieldInput design is ready"

This reverts commit 70c4db8.

* fix: resolved label identifier issue

---------

Co-authored-by: Thaïs Guigon <guigon.thais@gmail.com>
@FelixMalfait FelixMalfait mentioned this issue May 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeet1desai jeet1desai

Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed index column stickiness mobile jeet1desai/twenty
2 participants
@Bonapara @jeet1desai