Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all Composite Fields Import #5425

Open
charlesBochet opened this issue May 15, 2024 · 3 comments
Open

Support all Composite Fields Import #5425

charlesBochet opened this issue May 15, 2024 · 3 comments
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@charlesBochet
Copy link
Member

charlesBochet commented May 15, 2024

Scope & Context

Table views currently support an "Import" feature (that can be found in the "Option" menu)
This feature enable a user to upload a csv and automatically/manually map the csv columns to record fields.

Current behavior

Currently, the feature does not handle all composite fields (having multiple fieldColumns) properly ; selecting an ADDRESS or a CURRENCY does not work.

image

Expected behavior

Import feature supports ADDRESS and CURRENCY field types like it supports FULL_NAME field type.

  1. Check the behavior of Full_name by trying to make an import on People table. You'll see that fields list is exposing Firstname (Name) + Lastname (Name)
  2. We want something similar for Currency: Currency Code (Amount) + Amount Micros (Amount) (Amount being the field name)
  3. Similar for Address fields

Technical inputs

The work should be done in: packages/twenty-front/src/modules/object-record/spreadsheet-import/useSpreadsheetRecordImport.ts

Make sure to properly test this hook with composite case. It would also be nice to extract an util to ease testing.

@charlesBochet charlesBochet changed the title Support Composite Fields import Support all Composite Fields Import May 15, 2024
@charlesBochet charlesBochet added scope: front Issues that are affecting the frontend side only good first issue Good for newcomers labels May 15, 2024
@ijayhub
Copy link

ijayhub commented May 27, 2024

good evening, is it still, open? if it is can you assign it to me?

@charlesBochet
Copy link
Member Author

Hi @ijayhub, thanks for looking to contribute, it's much appreciated
The existing PR looks good, we still need to review it and propose a few improvements, no need to open a new one!
They are other good-first-issues available :)

@ijayhub
Copy link

ijayhub commented May 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants
@charlesBochet @ijayhub and others