You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Table views currently support an "Import" feature (that can be found in the "Option" menu)
This feature enable a user to upload a csv and automatically/manually map the csv columns to record fields.
Current behavior
Currently, the feature does not handle all composite fields (having multiple fieldColumns) properly ; selecting an ADDRESS or a CURRENCY does not work.
Expected behavior
Import feature supports ADDRESS and CURRENCY field types like it supports FULL_NAME field type.
Check the behavior of Full_name by trying to make an import on People table. You'll see that fields list is exposing Firstname (Name) + Lastname (Name)
We want something similar for Currency: Currency Code (Amount) + Amount Micros (Amount) (Amount being the field name)
Similar for Address fields
Technical inputs
The work should be done in: packages/twenty-front/src/modules/object-record/spreadsheet-import/useSpreadsheetRecordImport.ts
Make sure to properly test this hook with composite case. It would also be nice to extract an util to ease testing.
The text was updated successfully, but these errors were encountered:
charlesBochet
changed the title
Support Composite Fields import
Support all Composite Fields Import
May 15, 2024
Hi @ijayhub, thanks for looking to contribute, it's much appreciated
The existing PR looks good, we still need to review it and propose a few improvements, no need to open a new one!
They are other good-first-issues available :)
Scope & Context
Table views currently support an "Import" feature (that can be found in the "Option" menu)
This feature enable a user to upload a csv and automatically/manually map the csv columns to record fields.
Current behavior
Currently, the feature does not handle all composite fields (having multiple fieldColumns) properly ; selecting an ADDRESS or a CURRENCY does not work.
Expected behavior
Import feature supports ADDRESS and CURRENCY field types like it supports FULL_NAME field type.
Technical inputs
The work should be done in:
packages/twenty-front/src/modules/object-record/spreadsheet-import/useSpreadsheetRecordImport.ts
Make sure to properly test this hook with composite case. It would also be nice to extract an util to ease testing.
The text was updated successfully, but these errors were encountered: