Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error helpers for metadata settings inputs in form #5428

Open
ijreilly opened this issue May 15, 2024 · 1 comment
Open

Add error helpers for metadata settings inputs in form #5428

ijreilly opened this issue May 15, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@ijreilly
Copy link
Contributor

ijreilly commented May 15, 2024

Scope & Context

For now we are impeding users from trying to save an Object, a field or an option if the inputted value is not valid (because it starts with a digit or only contains empty char or is not transliterable, depending on the concerned data object). Let's add helpers in the form to help them understand what is wrong with their value (ex: "This field cannot be empty" / "Object names cannot start with digits".).

Expected behaviour can be clarified with @Bonapara

@Bonapara
Copy link
Member

image

We should use this design!

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=3007-69739&t=vYBsvz4IWvZL44UI-11

charlesBochet added a commit that referenced this issue May 15, 2024
## Context 
Fixes #5403

Transliteration is now integrated to form validation through the schema.
While it does not impede inputting an invalid value, it impedes
submitting a form that will fail as the transliteration is not possible.
Until then we were only performing the transliteration at save time in
the front-end, but it's best to provide the information as soon as
possible. Later we will add helpers to guide the user (eg "This name is
not valid": #5428).

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants
@Bonapara @ijreilly and others