-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Menu Contrast and Brightness in Dark Mode #5446
Comments
Disclaimer: This comment was automatically generated with AI. It can give some useful hints as to where to look for, but sometimes it can also give very inaccurate answers so takes this with a pinch of salt :).
// OverlayBackground.ts
const darkModeStyles = {
backdropFilter: 'blur(12px) saturate(200%) contrast(100%) brightness(130%)',
// other styles
};
References |
@charlesBochet, wouldn't this break the design system? How would you implement it? |
I think I might have done similar fixes in the past. Awaiting here. Can I take a look? |
Thanks @its-id! Assigning you |
Hi @its-id are you still on it? |
Hi, |
Thanks @its-id 🙏 |
I think this issue has already been fixed 3 days ago. can you confirm? @Bonapara once again, am really sorry for the delay. will not happen again. |
Don't worry, and thanks for contributing! Yes, it seems to have been fixed. |
Current Behavior
In dark mode, the menu borders are currently darker than the content, and the menu background appears too light.
Contrast is set to 50% in both light and dark mode
Desired Behavior
Contrast should be set to 100% in dark mode:
The text was updated successfully, but these errors were encountered: