-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign Timeline #1772
Redesign Timeline #1772
Conversation
Thanks @brendanlaschke! I've left comment on the code. Regarding the product behavior, we should make sure that the element fit in the page, without making it scrolling horizontically. We can either use %width for some element, or try a flex alternative. I'm unsure what's the best way to go here! |
front/src/modules/activities/timeline/components/TimelingeActivityGroup.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/activities/timeline/components/TimelingeActivityGroup.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/activities/timeline/components/TimelingeActivityGroup.tsx
Outdated
Show resolved
Hide resolved
Maybe @Bonapara will have a design fix for that ? |
Great solution! Should be working now for mobile. |
@brendanlaschke sorry about the slow review, I will take a look tomorrow, I think we are very close to merge it @Bonapara and I will take a decision on the responsive issue |
Waiting for activities refactor with new custom objects backend |
Redesign the tl to match figma (#1278).
The other "new" activities are not implemented im leaving that for later (and maybe someone else :) ), therefore it may look a bit silly with only Notes and Tasks implemented ...