Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Timeline #1772

Merged
merged 16 commits into from
Dec 4, 2023
Merged

Redesign Timeline #1772

merged 16 commits into from
Dec 4, 2023

Conversation

brendanlaschke
Copy link
Contributor

Redesign the tl to match figma (#1278).

The other "new" activities are not implemented im leaving that for later (and maybe someone else :) ), therefore it may look a bit silly with only Notes and Tasks implemented ...

Bildschirmfoto 2023-09-29 um 15 57 27

@charlesBochet
Copy link
Member

Thanks @brendanlaschke! I've left comment on the code. Regarding the product behavior, we should make sure that the element fit in the page, without making it scrolling horizontically. We can either use %width for some element, or try a flex alternative. I'm unsure what's the best way to go here!

image

On mobile, the issue is particularly present:
image

@brendanlaschke
Copy link
Contributor Author

Problem I still see is the mobile variant ...
Maybe for this design it is too much text ?

My thought would be for one line maybe:

-Avatar- created -Icon- "Some Note"

Or do you have a better idea how we could do this better for mobile and desktop?

Current situation:
Bildschirmfoto 2023-09-30 um 18 37 41

@lucasbordeau
Copy link
Contributor

Maybe @Bonapara will have a design fix for that ?

@charlesBochet charlesBochet added the blocked: design needed This doesn't seem right label Oct 4, 2023
@Bonapara
Copy link
Member

Bonapara commented Oct 6, 2023

image

Here we go!

Increase the spacing between lines from 12px to 24 px in mobile:

image

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=12021-35679&mode=design&t=OM6IvaXUAd2Idk3w-4

@brendanlaschke
Copy link
Contributor Author

Great solution! Should be working now for mobile.

@charlesBochet
Copy link
Member

@brendanlaschke sorry about the slow review, I will take a look tomorrow, I think we are very close to merge it @Bonapara and I will take a decision on the responsive issue

@lucasbordeau
Copy link
Contributor

Waiting for activities refactor with new custom objects backend

@lucasbordeau lucasbordeau merged commit 40b4e9f into twentyhq:main Dec 4, 2023
5 of 6 checks passed
@brendanlaschke brendanlaschke deleted the tl-redesign branch December 4, 2023 20:02
@charlesBochet charlesBochet mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants