Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove "pen icon" on Team member field #2384 #2549

Merged
merged 2 commits into from Dec 1, 2023
Merged

fix: Remove "pen icon" on Team member field #2384 #2549

merged 2 commits into from Dec 1, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2023

Motivation:
Closes #2384
Implementation:
Removed isFieldRelation(fieldDefinition) from useGetButtonIcon.ts
Testing:
fix2384
Hovering on the field in the "Account owner" column does not display a pencil icon.

@charlesBochet
Copy link
Member

@pokegh0st Thank you for the help.
So it's not as simple as that, the business rule should be: all relations except the one pointing to a WorkspaceMember (as WorkspaceMember won't have a detail page but all other objects will have)

@ghost
Copy link
Author

ghost commented Nov 18, 2023

Got it, I'm on it!

@ghost
Copy link
Author

ghost commented Nov 20, 2023

Hi @charlesBochet! I'm not exactly sure where to look. Could you guide me please? If it's too much hassle, that's fine too, just let me know so I step down to let someone with better understanding take over this

Copy link

github-actions bot commented Dec 1, 2023

CLA

Hello there and welcome to our project!
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.
Although we don't have a dedicated legal counsel, having this kind of agreement can protect us from potential legal issues or patent trolls.
Thank you for your understanding.

Generated by 🚫 dangerJS against 08785bd

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pokegh0st Here we go!
Sorry for the slow response, November was a very busy month with the migration!

@charlesBochet charlesBochet merged commit a301f45 into twentyhq:main Dec 1, 2023
4 of 6 checks passed
@charlesBochet charlesBochet mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "pen icon" on Team member field
1 participant