feat: add missing updateMany and deleteMany resolvers on flexible backend

[gitstart-twenty]

Fixes #2721

[magrinj]

@gitstart-twenty Juste use the name plural without the Many

Suggested change

	return `updateMany${pascalCase(objectMetadata.namePlural)}`;
	return `update${pascalCase(objectMetadata.namePlural)}`;

[gitstart-twenty]

Okay

[magrinj]

Suggested change

	return `deleteMany${pascalCase(objectMetadata.namePlural)}`;
	return `delete${pascalCase(objectMetadata.namePlural)}`;

[magrinj]

@gitstart-twenty It's a many query, so we should directly return records and not the first element of the array.

Suggested change

	)?.records[0];
	)?.records;

[magrinj]

Suggested change

	)?.records[0];
	)?.records;

[magrinj]

Suggested change

	): Promise<Record | undefined> {
	): Promise<Record[] | undefined> {

[magrinj]

Suggested change

	): Promise<Record | undefined> {
	): Promise<Record[] | undefined> {

[gitstart-twenty]

@magrinj Just one question, where are the return types for these auto-generated resolvers defined? Where do I specify that update[targetTableNamePlural] should not return Record but rather [Record!]

[gitstart-twenty]

When you check the return types of the mutations, you notice that not a single one returns an array(list) of items, all just return one item. For a quick example, even the create[collectionNamePlural] which one would expect to return the many created items, returns just one. Looks like this is the default behavior for these mutations(or at least it's what was implemented)

[gitstart-twenty]

@magrinj I've noticed the output types are defined in server > src > workspace > workspace-schema-builder > factories > root-type.factory.ts > RootTypeFactory > generateFields > outputType. In order for the type definitions not to default to a plain object, we need to make changes here and also make related modifications elsewhere. Should we return a connection for updateMany, deleteMany e.t.c

[magrinj]

@magrinj Just one question, where are the return types for these auto-generated resolvers defined? Where do I specify that update[targetTableNamePlural] should not return Record but rather [Record!]

In RootTypeFactory you should add the following changes:

--- root-type.factory.ts	2023-11-30 09:54:52
+++ root-type.factory.new.ts	2023-11-30 09:54:37
@@ -9,6 +9,7 @@
 import { TypeDefinitionsStorage } from 'src/workspace/workspace-schema-builder/storages/type-definitions.storage';
 import { getResolverName } from 'src/workspace/utils/get-resolver-name.util';
 import { getResolverArgs } from 'src/workspace/workspace-schema-builder/utils/get-resolver-args.util';
+import { TypeMapperService } from 'src/workspace/workspace-schema-builder/services/type-mapper.service';
 
 import { ArgsFactory } from './args.factory';
 import { ObjectTypeDefinitionKind } from './object-type-definition.factory';
@@ -25,6 +26,7 @@
 
   constructor(
     private readonly typeDefinitionsStorage: TypeDefinitionsStorage,
+    private readonly typeMapperService: TypeMapperService,
     private readonly argsFactory: ArgsFactory,
   ) {}
 
@@ -70,7 +72,7 @@
       for (const methodName of workspaceResolverMethodNames) {
         const name = getResolverName(objectMetadata, methodName);
         const args = getResolverArgs(methodName);
-        const outputType = this.typeDefinitionsStorage.getObjectTypeByKey(
+        const objectType = this.typeDefinitionsStorage.getObjectTypeByKey(
           objectMetadata.id,
           methodName === 'findMany'
             ? ObjectTypeDefinitionKind.Connection
@@ -84,7 +86,7 @@
           options,
         );
 
-        if (!outputType) {
+        if (!objectType) {
           this.logger.error(
             `Could not find a GraphQL type for ${objectMetadata.id} for method ${methodName}`,
             {
@@ -99,6 +101,10 @@
           );
         }
 
+        const outputType = this.typeMapperService.mapToGqlType(objectType, {
+          isArray: ['updateMany', 'deleteMany'].includes(methodName),
+        });
+
         fieldConfigMap[name] = {
           type: outputType,
           args: argsType,

[magrinj]

When you check the return types of the mutations, you notice that not a single one returns an array(list) of items, all just return one item. For a quick example, even the create[collectionNamePlural] which one would expect to return the many created items, returns just one. Looks like this is the default behavior for these mutations(or at least it's what was implemented)

Good catch on that, I guess it's an issue, if you can fix it and update the above patch to include createMany :)

[gitstart-twenty]

Hey @magrinj,
Thanks for the hints and the patch. I believe we're now good.

[magrinj]

Great job, thanks for your work !