Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming "Experience" to "Appearance" #2776

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Renaming "Experience" to "Appearance" #2776

merged 3 commits into from
Nov 30, 2023

Conversation

GsnMithra
Copy link
Contributor

I hope you're well. I'm suggesting a minor change: renaming the "Experience" tab to "Appearance." This aims for a more standard term, enhancing clarity.

Your thoughts on this adjustment would be greatly appreciated. Thank you for your time.

Before:
Before

After:
After

Copy link

github-actions bot commented Nov 30, 2023

CLA

Hello there and welcome to our project!
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.
Although we don't have a dedicated legal counsel, having this kind of agreement can protect us from potential legal issues or patent trolls.
Thank you for your understanding.

Generated by 🚫 dangerJS against b14090b

@@ -0,0 +1,61 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GsnMithra could you remove this file and add it the .gitignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for replying. Yea I have removed the file and also added it to .gitignore with the upcoming commits.

@charlesBochet
Copy link
Member

@GsnMithra We have discussed with @Bonapara and we think that this change is a good idea as long as the "Experience" section does not propose further customizations that would not only be tied to the "Appearance"

I've made a comment about idea file. Once fixed, we can merge it, thank you!

@FelixMalfait
Copy link
Member

Thanks for the proposal @GsnMithra!
The reasoning was that some more generic items would fit into that category (e.g. what page do you open by default when you open the app, what default timezone, etc.). If we were to rename I'd rather go with something even more generic (e.g. "Preferences") rather than something more specific, to avoid future dev work. This is something we will necessarily refactor, and moving from Appearance to Experience pushes that refactor closer in time.

@GsnMithra
Copy link
Contributor Author

Hey, thanks for replying. I knew that changing the "Experience" tab to "Appearance" would narrow the options on that page. However, when I first tried to search for the dark mode, I didn't find it quickly because I was fairly new to Twenty. Considering a newcomer, it would also take a fair amount of time for a simple toggle. So in my opinion changing it to "Appearance" could be nice.

Thank you for your time.

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charlesBochet charlesBochet merged commit c2131a2 into twentyhq:main Nov 30, 2023
2 checks passed
@charlesBochet charlesBochet mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants