fix: FieldMetadata default value and options better validation #2785
Conversation
magrinj
force-pushed
the
fix/fieldmetadata-validation
branch
2 times, most recently
from
4a2b3fa
to
6a3d351
Compare
magrinj
changed the title
There was a problem hiding this comment.
Can't generate something smaller for now... As it's map file and bundled sources
server/src/metadata/field-metadata/validators/is-field-metadata-options.validator.ts
Outdated
Show resolved
Hide resolved
| @Args('input') input: UpdateOneFieldMetadataInput, | ||
| @AuthWorkspace() { id: workspaceId }: Workspace, | ||
| ) { | ||
| return this.fieldMetadataService.updateOne(input.id, { |
There was a problem hiding this comment.
It seems we lost a few checks such as rejecting updates on standard fields (except for isActive) + updates on certain fields for custom or am I missed something?
There was a problem hiding this comment.
@Weiko I'll take a look on that
There was a problem hiding this comment.
You're right, I've fix the issue
…a-options.validator.ts Co-authored-by: Weiko <corentin@twenty.com>
magrinj
force-pushed
the
fix/fieldmetadata-validation
branch
from
ac2161e
to
a0fc109
Compare
| @@ -159,6 +159,15 @@ export class FieldMetadataService extends TypeOrmQueryService<FieldMetadataEntit | |||
| throw new NotFoundException('Field does not exist'); | |||
| } | |||
|
|
|||
| if (existingFieldMetadata.isCustom === false) { | |||
| // We can only update the isActive field for standard fields | |||
There was a problem hiding this comment.
Nit: not a blocker but it could be a bit deceiving for the api user since we transform the input and not throw any error if something else than isActive is changed
There was a problem hiding this comment.
@Weiko Yes it's a quick change, we can maybe create another default validator for isCustom properties, but you told me that the front-end send all the input informations and I didn't want to break it
This PR, in how
defaultValueandoptionswere validated.It nos use asynchronous validators to support
createandupdatevalidation based on the type of the field.