fix: avoid create custom entities with the same name #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA
Hello there and welcome to our project! |
server/src/metadata/object-metadata/hooks/before-create-one-object.hook.ts
Outdated
Show resolved
Hide resolved
server/src/metadata/object-metadata/hooks/before-create-one-object.hook.ts
Outdated
Show resolved
Hide resolved
Weiko
reviewed
Dec 5, 2023
server/src/metadata/object-metadata/hooks/before-create-one-object.hook.ts
Outdated
Show resolved
Hide resolved
server/src/metadata/object-metadata/hooks/before-create-one-object.hook.ts
Outdated
Show resolved
Hide resolved
server/src/metadata/object-metadata/hooks/before-create-one-object.hook.ts
Outdated
Show resolved
Hide resolved
Weiko
reviewed
Dec 5, 2023
server/src/metadata/object-metadata/hooks/before-create-one-object.hook.ts
Outdated
Show resolved
Hide resolved
server/src/metadata/object-metadata/hooks/before-create-one-object.hook.ts
Outdated
Show resolved
Hide resolved
server/src/metadata/object-metadata/hooks/before-create-one-object.hook.ts
Outdated
Show resolved
Hide resolved
server/src/metadata/object-metadata/hooks/before-create-one-object.hook.ts
Outdated
Show resolved
Hide resolved
|
@Weiko can you take a look please? I left only four entities as requested and disabled strong input check. |
Weiko
approved these changes
Dec 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've added the flexible back-end, we're now able to create custom objects per workspaces.
As the core graphQL schema is seeing merged with the workspace schema we must avoid conflict in the naming of custom objects against core and standards entities.
Fixes #2768