Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachments add more file extensions #2803

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Attachments add more file extensions #2803

merged 1 commit into from
Dec 3, 2023

Conversation

brendanlaschke
Copy link
Contributor

adds some extensions

if we don't want to move the calculation to the backend (type is already saved) as discussed with @FelixMalfait it closes #2797

@brendanlaschke brendanlaschke marked this pull request as ready for review December 3, 2023 18:27
FelixMalfait
FelixMalfait approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@FelixMalfait FelixMalfait merged commit de2f721 into twentyhq:main Dec 3, 2023
5 of 10 checks passed
@brendanlaschke brendanlaschke deleted the attachments-more-file-extensions branch December 4, 2023 20:02
@charlesBochet charlesBochet mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixMalfait FelixMalfait FelixMalfait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move attachment type to the backend
2 participants
@brendanlaschke @FelixMalfait