Feature: Add Empty State Display for Tables #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA
Hello there and welcome to our project! |
thaisguigon
force-pushed
the
feature-empty-state-display-for-tables
branch
from
7dfe081
to
72a4a8b
Compare
thaisguigon
requested changes
Dec 7, 2023
There was a problem hiding this comment.
Hi @tmahabir, thank you for your contribution!
I rebased your PR as some important fixes were merged recently. Left a few minor comments, otherwise LGTM!
front/src/modules/object-record/record-table/components/RecordTable.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/object-record/record-table/components/RecordTable.tsx
Outdated
Show resolved
Hide resolved
…ub.com/tmahabir/twenty into feature-empty-state-display-for-tables
|
Hi @thaisguigon ! Thank you for the comments, I've addressed them in my most recent commits! |
thaisguigon
approved these changes
Dec 8, 2023
|
Merging it! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1991
Added empty state display for when there are no records for Standard objects and Custom objects.
Here's a visual of the change:
twenty-empty-state-display.mov