Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest api updates #2844

Merged
merged 39 commits into from
Dec 6, 2023
Merged

Rest api updates #2844

merged 39 commits into from
Dec 6, 2023

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Dec 5, 2023

close #2822
close #2792

  • Code cleaning -> split huge file into multiple tested utils and factories
  • Add missing comparators like, ilike, in, is
  • surround string values with ""
  • fix parsing for values containing ':' like dates

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments!

Copy link
Member

@magrinj magrinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martmull Great job, some comments !

Comment on lines +35 to +36
const [fieldsString, direction] = orderByItem
.replace(']', '')

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This replaces only the first occurrence of ']'.
@martmull martmull force-pushed the rest-api-updates branch 3 times, most recently from 1493fbe to a3f9400 Compare December 6, 2023 13:29
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We merge!

@charlesBochet charlesBochet merged commit b72d6a9 into main Dec 6, 2023
8 of 13 checks passed
@charlesBochet charlesBochet deleted the rest-api-updates branch December 6, 2023 15:55
@charlesBochet charlesBochet mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve api-rest feature New LOCAL_SERVER_URL variable
3 participants