Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optimistic rendering issues on views #2851

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fix optimistic rendering issues on views #2851

merged 3 commits into from
Dec 6, 2023

Conversation

charlesBochet
Copy link
Member

In this PR:

  • I'm moving fetchMore ref on TableRecordBody to TableRecordRow to avoid re-rendering the whole body
  • I'm removing onCompleted logic on Views loading as this is not triggered by cache update + refetch queries

charlesBochet
charlesBochet commented Dec 6, 2023
View reviewed changes
front/src/modules/views/components/UpdateViewButtonGroup.tsx
</DropdownMenuItemsContainer>
)}
</StyledContainer>
<DropdownScope dropdownScopeId={UpdateViewDropdownId}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the new way of doing it. We have a Dropdown component that we use and not compose our own Dropdown manually

@charlesBochet charlesBochet merged commit 076a67b into main Dec 6, 2023
9 of 13 checks passed
@charlesBochet charlesBochet deleted the optimistic-views branch December 6, 2023 15:55
@charlesBochet charlesBochet mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weiko Weiko Weiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charlesBochet @Weiko