Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2795-fix(front): ObjectNamePlural added as Page Header title #2852

Merged

Conversation

Kanav-Arora
Copy link
Contributor

@Kanav-Arora Kanav-Arora commented Dec 6, 2023

Closes #2795

I have used ObjectMetaData for icons instead of hardcoding. So for new workspaces this approach will work

Screenshot 2023-12-06 at 8 13 58 PM

@Kanav-Arora Kanav-Arora marked this pull request as draft December 6, 2023 14:47
Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for contributing.

@bosiraphael bosiraphael merged commit b2912f4 into twentyhq:main Dec 7, 2023
4 of 5 checks passed
@charlesBochet charlesBochet mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show object name and icon in top bar instead of showing "Objects"
3 participants