Throw an error if workspace id has no object #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martmull
commented
Dec 7, 2023
•
martmull
commented
- throw an error if token is valid but associated workspace don't have any objects
- set all routes object names to plural -> https://stackoverflow.com/questions/6845772/should-i-use-singular-or-plural-name-convention-for-rest-resources
- fix graphql query url
- handle graphql errors
magrinj
approved these changes
Dec 7, 2023
martmull
force-pushed
the
fix-api-rest
branch
from
2310857
to
c11b85d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -27,6 +27,7 @@ import OptionTable from '@site/src/theme/OptionTable' | |||
| ['REDIS_HOST', '127.0.0.1', 'Redis connection host'], | |||
| ['REDIS_PORT', '6379', 'Redis connection port'], | |||
| ['FRONT_BASE_URL', 'http://localhost:3001', 'Url to the hosted frontend'], | |||
| ['LOCAL_SERVER_URL', 'http://localhost:3000', 'Url to the hosted server'], | |||
There was a problem hiding this comment.
SERVER_URL everywhere actually
martmull
force-pushed
the
fix-api-rest
branch
from
c11b85d
to
f5c9552
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.