Feat/object metadata item identifiers #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasbordeau
commented
Dec 7, 2023
lucasbordeau
commented
- Updated metadata graphql schema and fixed typing issues (with Enum => MultiSelect mostly)
- Added seeds for identifier fields on company and person object metadata
- Added a new hook to create a mapper to generate record identifier from a record
| }) => { | ||
| return (record: any): ObjectRecordIdentifier => { | ||
| switch (objectMetadataItem.nameSingular) { | ||
| case CoreObjectNameSingular.WorkspaceMember: |
There was a problem hiding this comment.
this should be replaced by a dynamic computation:
- workspaceMember case: for FullName field types: firstName + ' ' + lastName
- opportunity: OK to keep it hardcoded, this is temporary and Opportunity will soon get their own name field
| ? getLogoUrlFromDomainName(imageIdentifierFieldValue ?? '') | ||
| : imageIdentifierFieldValue ?? null; | ||
|
|
||
| console.log({ |
| @@ -0,0 +1,6 @@ | |||
| export enum CoreObjectNameSingular { | |||
| @@ -74,7 +80,31 @@ export const seedObjectMetadata = async ( | |||
| workspaceId: SeedWorkspaceId, | |||
| isActive: true, | |||
| isSystem: false, | |||
| labelIdentifierFieldMetadataId: SeedPersonFieldMetadataIds.Email, | |||
There was a problem hiding this comment.
you'll likely get conflict with @Weiko work here!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.