Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Settings/Accounts/Emails page #2867

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

thaisguigon
Copy link
Contributor

Closes #2819

@thaisguigon thaisguigon marked this pull request as ready for review December 7, 2023 17:58
@charlesBochet charlesBochet self-assigned this Dec 8, 2023
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

})
}
/>
<NavigationDrawerSection>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice for the whole section, the API looks easy to use

@@ -18,8 +18,7 @@ const StyledMainContainer = styled.div`
flex-direction: row;
gap: ${({ theme }) => theme.spacing(2)};
min-height: 0;
padding-bottom: ${({ theme }) => theme.spacing(4)};
padding-right: ${({ theme }) => theme.spacing(3)};
padding: ${({ theme }) => theme.spacing(0, 3)};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!

@charlesBochet charlesBochet merged commit 1f40c45 into main Dec 8, 2023
10 of 14 checks passed
@charlesBochet charlesBochet deleted the feat/add-settings-accounts-emails-page branch December 8, 2023 10:10
@charlesBochet charlesBochet mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accounts/Emails - Create page
2 participants