fix: relation on self not working #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -168,16 +168,16 @@ export class RelationMetadataService extends TypeOrmQueryService<RelationMetadat | |||
|
|
|||
| const createdFieldMap = createdFields.reduce((acc, fieldMetadata) => { | |||
| if (fieldMetadata.type === FieldMetadataType.RELATION) { | |||
| acc[fieldMetadata.objectMetadataId] = fieldMetadata; | |||
| acc[fieldMetadata.name] = fieldMetadata; | |||
| } | |||
|
|
|||
| return acc; | |||
| }, {}); | |||
|
|
|||
| const createdRelationMetadata = await super.createOne({ | |||
| ...record, | |||
There was a problem hiding this comment.
I'm surprise about the usage of "record" here!?
it should be relation or relationMetadata
There was a problem hiding this comment.
Doesn't really have preference on that as it's referencing the user input, in fact it should be something like relationInput but name record is used in other places in the code for inputs.
I can take a quick look and rename them ? Or maybe we can create a small ticket for that ?
There was a problem hiding this comment.
let's create a small ticket for that! But yes record should be only used to describe the data itself.
The full naming on the project is: an object record is an instance of an object metadata (class)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relation on self was not working, this PR fix the ticket #2599.
You can now create relation like this one
Person <-> Person.