Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relation between standard objects #2878

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Dec 8, 2023

This PR fixes a few issues

  • The FE code was sending a viewId to a view property instead of viewId during viewField creation (after relation creation). Note: this part should be moved to the BE.
  • The toDescription field is optional, when a description was missing we were concatenating it to format the relation description and it was containing undefined, now we don't try to create a description if none is provided.
  • Fixes the targetColumnMap not defined when we were creating relations to standard objects. In the backend we run the query against pg_graphql with a fieldAlias however if the field is custom and targetColumnMap is empty we query it with undefined like this bar: undefined (see RelationFieldAliasFactory). The alias is actually redundant here it seems so maybe there are things we can improve 馃 (cc @magrinj)

@charlesBochet
Copy link
Member

Let's also fix opportunity.person (should be nullable) and note.author (should be prefilled by the FE for now)

@charlesBochet charlesBochet merged commit b68f5cd into main Dec 8, 2023
11 of 15 checks passed
@charlesBochet charlesBochet deleted the c--fix-standard-relation-creation branch December 8, 2023 14:50
@charlesBochet charlesBochet mentioned this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants