Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update token verification and fix typo #2889

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Update token verification and fix typo #2889

merged 2 commits into from
Dec 8, 2023

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Dec 8, 2023 •
edited

  • factorize token validation
  • fix typo in graphql query generations

charlesBochet
charlesBochet reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments!

server/src/core/api-rest/api-rest-query-builder/factories/find-one-query.factory.ts Show resolved Hide resolved
@martmull martmull marked this pull request as draft December 8, 2023 15:35
charlesBochet
charlesBochet approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you :)

@martmull martmull marked this pull request as ready for review December 8, 2023 16:10
@charlesBochet charlesBochet merged commit 9b7d7b2 into main Dec 8, 2023
9 of 13 checks passed
@charlesBochet charlesBochet deleted the fix-api-rest-typo branch December 8, 2023 16:42
@charlesBochet charlesBochet mentioned this pull request Dec 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees
No one assigned
Labels
PR: awaiting author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martmull @charlesBochet