Fix command menu keyboard navigation #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Matheus <matheus_benini@hotmail.com>
lucasbordeau
changed the title
lucasbordeau
requested changes
Dec 12, 2023
| @@ -3,13 +3,14 @@ import { IconComponent } from '@/ui/display/icon/types/IconComponent'; | |||
| export enum CommandType { | |||
| Navigate = 'Navigate', | |||
| Create = 'Create', | |||
| Other = 'Other', | |||
There was a problem hiding this comment.
Other is too vague and at risk of being a catch-all type for everything, we can put 'OpenDrawer' or something like that.
| @@ -118,6 +120,17 @@ export const CommandMenu = () => { | |||
| ], | |||
| }, | |||
| limit: 3, | |||
| onCompleted: (data) => { | |||
There was a problem hiding this comment.
We should put all the onCompleted in useEffects, because onCompleted isn't retriggered when we're updating the cache with optimistic effects.
There was a problem hiding this comment.
Hey @lucasbordeau Adding a useEffect just caused too many rerenders, please check out the change I went with.
Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Matheus <matheus_benini@hotmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Matheus <matheus_benini@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to: #2778 (comment)
Fixes #2746