Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/complete filter order by types #2943

Merged
merged 10 commits into from
Dec 12, 2023
Merged

Feat/complete filter order by types #2943

merged 10 commits into from
Dec 12, 2023

Conversation

lucasbordeau
Copy link
Contributor

  • Added a new ObjectRecordFilter type for typing filter in object requests
  • Typed the function that creates those filters
  • Typed the hooks that send filters to server
  • Type OrderBy fields as well
  • Removed "any" typing where we used filter and order by

@charlesBochet charlesBochet self-assigned this Dec 12, 2023
charlesBochet
charlesBochet approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo! Typing expert ;)

@lucasbordeau lucasbordeau merged commit 2a4ab2f into main Dec 12, 2023
6 of 11 checks passed
@lucasbordeau lucasbordeau deleted the feat/complete-filter-order-by-types branch December 12, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees

@charlesBochet charlesBochet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucasbordeau @charlesBochet