Use SelectableList in RelationPicker, SingleEntitySelectBase and MultipleEntitySelect #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kanav-Arora
changed the title
|
@Kanav-Arora we were having linter issues (it was broken). I've used your PR to fix it :p Could you pull your branch (I've pushed on it), run "yarn" and then "yarn lint" (from front folder or yarn nx lint twenty-front from root) |
|
Regarding your fix and the refactoring, LGTM, I will give another try once linter is fixed! |
|
Hi @charlesBochet |
charlesBochet
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2747
SelectedItemId state is to be updated if and only if there's a possibility of new id. So now up arrow won't work if 0th item is selected. Same for all other keys.