Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2813 create message channel data model #2952

Merged
merged 9 commits into from
Dec 12, 2023
Merged

2813 create message channel data model #2952

merged 9 commits into from
Dec 12, 2023

Conversation

bosiraphael
Copy link
Contributor

Closes #2813

@bosiraphael bosiraphael linked an issue Dec 12, 2023 that may be closed by this pull request
Create message-channel data model #2813
Closed
Weiko
Weiko approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM left a last comment @bosiraphael

...er/src/workspace/workspace-sync-metadata/standard-objects/message-channel.object-metadata.ts Outdated
icon: 'IconUserCircle',
joinColumn: 'connectedAccountId',
})
connectedAccount: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
connectedAccount: string;
connectedAccount: ConnectedAcountObjectMetadata;

@bosiraphael bosiraphael merged commit 6bc7a58 into main Dec 12, 2023
1 of 6 checks passed
@bosiraphael bosiraphael deleted the 2813-create-message-channel-data-model branch December 12, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weiko Weiko Weiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create message-channel data model
2 participants
@bosiraphael @Weiko