-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2980-Fix: CommandGroup background #2985
2980-Fix: CommandGroup background #2985
Conversation
@Kanav-Arora Let's introduce a new boxShadow in theme: Light mode: Dark mode: (using grayScale.gray100 as others) I've also noticed that boxShadow extraLight is not used anymore in the code and not part of Figma, let's remove it |
Hi @charlesBochet |
@Kanav-Arora could you add screenshots? |
@charlesBochet PFA |
@Kanav-Arora, thank you for your work on this. In addition to fixing the box shadow, we also need to correct the background colors. Here's what we can do:
|
Hi @charlesBochet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I have made last changes based on discussion with @Bonapara
Closes #2980