2973-feat: Skeleton Loading Added #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbordeau
previously requested changes
Dec 15, 2023
packages/twenty-front/src/modules/object-record/components/RecordShowPage.tsx
Outdated
Show resolved
Hide resolved
|
Hi @lucasbordeau |
There was a problem hiding this comment.
@Kanav-Arora, I have left additional comments, then we can merge!
packages/twenty-front/src/modules/object-record/components/RecordShowPage.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageLeftContainer.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/components/RecordShowPage.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageRightContainer.tsx
Outdated
Show resolved
Hide resolved
|
@Kanav-Arora any update on this one? :) |
|
Hi @charlesBochet on it |
|
Hi @charlesBochet |
charlesBochet
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
@Kanav-Arora I have removed if (!record) return <></>; on line 132 which was making your fix not actually applied. And I have fixed the consequences of this.
Thanks for the help, as always!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2973
I found the issue but was unable to reproduce it, but I have made some changes if they work.