Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixs/reviews setups #3067

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Conversation

Varrooo
Copy link
Contributor

@Varrooo Varrooo commented Dec 18, 2023

See for context: #2932

The function keyword is not recognize by every POSIX-compliant shell.  The function keyword is a bashism, a bash extension. POSIX syntax does not use function and mandates the use of parenthesis.

This commit fixes the two issues :
./linux/provision-postgres-linux.sh: 9: function: not found
./linux/provision-postgres-linux.sh: 15: Syntax error: "}" unexpected
There were two number 3's, everything should be correct now.
Copy link

CLA

Hello there and welcome to our project!
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.
Although we don't have a dedicated legal counsel, having this kind of agreement can protect us from potential legal issues or patent trolls.
Thank you for your understanding.

Generated by 🚫 dangerJS against 1168412

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -154,7 +154,7 @@ You can access this using `twenty` postgres user (password: `twenty`)
</Tabs>


## Step 3: Setup environment variables
## Step 4: Setup environment variables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 :)

@@ -75,5 +75,5 @@ fi

# Run the init.sql to setup database
echo_header $GREEN "Step [4/4]: Setting up database..."
cp ./postgres/init.sql /tmp/init.sql
cp ./init.sql /tmp/init.sql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@charlesBochet charlesBochet merged commit 0f7ddd2 into twentyhq:main Dec 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants