-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixs/reviews setups #3067
Fixs/reviews setups #3067
Conversation
The function keyword is not recognize by every POSIX-compliant shell. The function keyword is a bashism, a bash extension. POSIX syntax does not use function and mandates the use of parenthesis. This commit fixes the two issues : ./linux/provision-postgres-linux.sh: 9: function: not found ./linux/provision-postgres-linux.sh: 15: Syntax error: "}" unexpected
There were two number 3's, everything should be correct now.
CLA
Hello there and welcome to our project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@@ -154,7 +154,7 @@ You can access this using `twenty` postgres user (password: `twenty`) | |||
</Tabs> | |||
|
|||
|
|||
## Step 3: Setup environment variables | |||
## Step 4: Setup environment variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 :)
@@ -75,5 +75,5 @@ fi | |||
|
|||
# Run the init.sql to setup database | |||
echo_header $GREEN "Step [4/4]: Setting up database..." | |||
cp ./postgres/init.sql /tmp/init.sql | |||
cp ./init.sql /tmp/init.sql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
See for context: #2932