feat(workspace-resolver): prevent deletion of demo workspaces (#2207) #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
khakimov
commented
Dec 19, 2023
khakimov
commented
|
|
||
| // Check if the id is in the list of demo workspaceIds | ||
| if (demoWorkspaceIds.includes(id)) { | ||
| throw new Error('Cannot delete a demo workspace.'); |
There was a problem hiding this comment.
@khakimov could you throw a ForbiddenException instead? This will (ongoing work) be parsed by our exception handler and nicely sent back through graphql response.
There was a problem hiding this comment.
added checks in deleteUser as well to prevent removing current user from the demo workspace.
…sages (twentyhq#2207) - ForbiddenException messages for attempts to delete users and workspaces associated with demo accounts
charlesBochet
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.