Add sync driver for queue messages #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magrinj
approved these changes
Dec 19, 2023
| @@ -38,15 +43,19 @@ export class MessageQueueModule { | |||
| return boss; | |||
| } | |||
|
|
|||
| return new BullMQDriver(config.options); | |||
| if (config.type === MessageQueueDriverType.BullMQ) { | |||
There was a problem hiding this comment.
@Weiko Maybe a switch...case is more readable here
Weiko
commented
Dec 19, 2023
| @@ -148,7 +148,7 @@ export class EnvironmentService { | |||
| getMessageQueueDriverType(): MessageQueueDriverType { | |||
| return ( | |||
| this.configService.get<MessageQueueDriverType>('MESSAGE_QUEUE_TYPE') ?? | |||
| MessageQueueDriverType.PgBoss | |||
| MessageQueueDriverType.Sync | |||
There was a problem hiding this comment.
We now use sync by default
| return await job.handle(data); | ||
| } | ||
| work<T>(queueName: MessageQueue, handler: ({ data, id }: { data: T; id: string; }) => void | Promise<void>) { | ||
| return; |
There was a problem hiding this comment.
Nothing to do here, no worker to expect.
| const jobClassName = getJobClassName(jobName); | ||
| const job: MessageQueueJob<MessageQueueJobData> = this.jobsModuleRef.get(jobClassName, { strict: true }); | ||
|
|
||
| return await job.handle(data); |
There was a problem hiding this comment.
We directly execute the function in sync mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We've recently added a worker for our queues however the worker needs to be running in a separated app to execute jobs. To improve the dev experience and because workers are not always meaningful for local development, this PR adds a sync driver which means jobs will be executed directly without going through a queue.
Test