fix: sentry doesn't catch exceptions from flexible backend #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,6 +11,10 @@ export class GlobalExceptionFilter implements GqlExceptionFilter { | |||
| ) {} | |||
|
|
|||
| catch(exception: unknown) { | |||
| return this.catchException(exception); | |||
| @@ -27,61 +20,10 @@ import { WorkspaceModule } from './workspace/workspace.module'; | |||
| ConfigModule.forRoot({ | |||
| isGlobal: true, | |||
| }), | |||
| GraphQLModule.forRoot<YogaDriverConfig>({ | |||
| context: ({ req }) => ({ req }), | |||
| GraphQLModule.forRootAsync<YogaDriverConfig>({ | |||
There was a problem hiding this comment.
Great to have extracted its own service, it was weird to have the dynamic schema at the "root" in app.module.ts
magrinj
force-pushed
the
fix/sentry-exceptions
branch
from
558d2c2
to
49d41d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As conditional schema creation is outside Nest.JS "flow" we have to manually instantiate the exception filters properly send the errors to Sentry
Fix #2916