Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour Fix on new record addition #3113

Merged
merged 8 commits into from
Jan 5, 2024

Conversation

Kanav-Arora
Copy link
Contributor

@Kanav-Arora Kanav-Arora commented Dec 21, 2023

Closes #3069

I have created a function which accepts the index instead of hardcoding it just for (0,0) it accepts row and column as parameters so that it can be used in future to toggle edit mode of specific cells.

I had to call this directly without useTableCell api because createObject doesn't have a scope but ig its working perfectly.

@Kanav-Arora Kanav-Arora marked this pull request as ready for review December 22, 2023 06:48
@Kanav-Arora
Copy link
Contributor Author

Hi @charlesBochet @Bonapara
Please give this a look if this is what you were expecting for this issue

Screen.Recording.2023-12-22.at.12.23.11.PM.mov

P.S: I don't know why its giving apollo error. Ig on click outside persistField function is being called which needs to be changed later.

@Bonapara
Copy link
Member

The behavior works well! However, the floating input appears cropped in the cell.

@Kanav-Arora
Copy link
Contributor Author

The behavior works well! However, the floating input appears cropped in the cell.

Umm I don't think so that problem arised due to this change of code. I'll create another issue for that to check the problem.

@Kanav-Arora Kanav-Arora changed the title Delete record if no company added Behaviour Fix on new record addition Dec 22, 2023
@Kanav-Arora
Copy link
Contributor Author

Hi @FelixMalfait
Can you take a look on this?

@FelixMalfait
Copy link
Member

I agree it's not linked to your changes @Kanav-Arora.
@Bonapara would you mind creating an issue with exact specs? I'd do it but I'm not sure exactly how you want it to be.

@Kanav-Arora setting back to "waiting for review", someone should review it on Monday. Sorry for the delay

@charlesBochet
Copy link
Member

charlesBochet commented Jan 3, 2024

@Kanav-Arora I'm taking a look tomorrow morning!
I have merged other PRs that were in the way of this one today

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kanav-Arora we used your PR to add refacto on top! Sorry about that!

Thanks for the contribution!

@charlesBochet charlesBochet merged commit 8455e15 into twentyhq:main Jan 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New line behavior on table views
5 participants