Activity editor add File block #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh this is super cool! |
|
I tried to upload a file but I only see a request |
lucasbordeau
reviewed
Jan 2, 2024
The upload method was behind the image block feature flag - it's fixed now :) |
|
@lucasbordeau Leaving this one to you as you are working on this part |
lucasbordeau
approved these changes
Jan 5, 2024
|
|
||
| import { FileBlock } from './FileBlock'; | ||
|
|
||
| export const blockSpecs: any = { |
There was a problem hiding this comment.
Is it possible to have a type here ?
There was a problem hiding this comment.
Im not sure about the types on this one - it's kind of weird what is expected by the Blockeditor generics. Maybe you or someone else has an idea how to do this the right way :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bildschirmaufnahme.2023-12-23.um.13.38.36.mov
For now it works but its not quite production ready :)
But I think with a bit of work on cmd+c/v and drop events this could work really well - maybe we also want to change the design of the block or convert it to an inline content?