Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve menuitem btn design #3152

Merged
merged 2 commits into from
Jan 3, 2024
Merged

feat: improve menuitem btn design #3152

merged 2 commits into from
Jan 3, 2024

Conversation

CzhCN0
Copy link
Contributor

@CzhCN0 CzhCN0 commented Dec 25, 2023

closes #3098

@CzhCN0 CzhCN0 force-pushed the feature/issue-3098-improve-menu-item-button-design branch from 3e575db to 9986250 Compare December 25, 2023 14:37
@CzhCN0 CzhCN0 force-pushed the feature/issue-3098-improve-menu-item-button-design branch from d2adbc2 to 58f3c68 Compare December 25, 2023 14:44
@twentyhq twentyhq deleted a comment from vercel bot Dec 25, 2023
@lucasbordeau
Copy link
Contributor

@Bonapara How should we handle overflowing ?

image

@lucasbordeau lucasbordeau added the blocked: design needed This doesn't seem right label Dec 26, 2023
@CzhCN0
Copy link
Contributor Author

CzhCN0 commented Dec 27, 2023

@Bonapara How should we handle overflowing ?

image

This is exactly the concern I expressed in the issue. We need a solution.

@Bonapara
Copy link
Member

Bonapara commented Jan 2, 2024

Is it possible to crop the text when the menu-item is hovered? Ideally, the text should span the full length by default, but be cropped during hover to avoid overlapping with buttons.

@CzhCN0
Copy link
Contributor Author

CzhCN0 commented Jan 3, 2024

Is it possible to crop the text when the menu-item is hovered? Ideally, the text should span the full length by default, but be cropped during hover to avoid overlapping with buttons.

That sounds great! I'll try to implement this effect.

@CzhCN0 CzhCN0 force-pushed the feature/issue-3098-improve-menu-item-button-design branch from 5ca7cc3 to d807d33 Compare January 3, 2024 14:53
@CzhCN0
Copy link
Contributor Author

CzhCN0 commented Jan 3, 2024

Jan-03-2024 22-13-32
@Bonapara Is that the intended effect?

@charlesBochet charlesBochet added PR: awaiting review and removed blocked: design needed This doesn't seem right labels Jan 3, 2024
charlesBochet
charlesBochet approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charlesBochet charlesBochet merged commit f36fa9a into twentyhq:main Jan 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees
No one assigned
Labels
PR: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved menu item button design
4 participants
@CzhCN0 @lucasbordeau @Bonapara @charlesBochet