Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#3150 - Esc and click outside is working to close searchbox #3168

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Issue#3150 - Esc and click outside is working to close searchbox #3168

merged 2 commits into from
Dec 29, 2023

Conversation

seAfnan
Copy link
Contributor

@seAfnan seAfnan commented Dec 27, 2023

Expected behavior

twenty-bug-solved

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2023 •
edited

CLA

Hello there and welcome to our project!
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.
Although we don't have a dedicated legal counsel, having this kind of agreement can protect us from potential legal issues or patent trolls.
Thank you for your understanding.

Generated by 🚫 dangerJS against 89ba633

@Kanav-Arora
Copy link
Contributor

Hi @seAfnan
I think this 'esc to cancel' can be written as just 'esc' in a greyish text. @Bonapara what do you think?

martmull
martmull requested changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @seAfnan, thank you for your contribution. Great job! Think we need to validate the design with @Bonapara. I have also left some comments

packages/twenty-front/src/modules/command-menu/components/CommandMenu.tsx Outdated Show resolved Hide resolved
packages/twenty-front/src/modules/command-menu/components/CommandMenu.tsx Outdated Show resolved Hide resolved
packages/twenty-front/src/modules/command-menu/components/CommandMenu.tsx Outdated Show resolved Hide resolved
packages/twenty-front/src/modules/command-menu/components/CommandMenu.tsx Show resolved Hide resolved
@seAfnan
Font size, margin + 'esc' only
89ba633 
Font size changed to theme specific, have a handsome margin to the top right of search box for text "Esc to cancel". Passing 'esc' only to escape.
@vercel Vercel
Copy link

vercel bot commented Dec 28, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
twenty-twenty-website ❌ Failed (Inspect) Dec 28, 2023 8:46am

@seAfnan
Copy link
Contributor Author

seAfnan commented Dec 28, 2023

Above changes done.

@martmull
Copy link
Contributor

Thank you for your changes, looks good to me

@martmull martmull merged commit f827912 into twentyhq:main Dec 29, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martmull martmull martmull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seAfnan @Kanav-Arora @martmull @lucasbordeau