Replace all hardcoded core object name by enum #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Grabmeier <flo.grabmeier@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Can someone tell me why the test failed? I can't see the error code |
packages/twenty-front/src/modules/activities/hooks/useOpenCreateActivityDrawer.ts
Outdated
Show resolved
Hide resolved
|
Nice, just a minor typo |
lucasbordeau
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3164.
As described in the issue, all hardcoded
objectNameSingularstrings have been replaced with the corresponding enum, which has also been extended for this case