3157 refactor scoped states to move to v3 #3180
Conversation
TODOs/FIXMEs:
|
| const { selectedRowIdsScopeInjector } = getRecordTableScopeInjector(); | ||
|
|
||
| const { injectSelectorSnapshotValueWithRecordTableScopeId } = | ||
| useRecordTableScopedStates(recordTableScopeId); |
There was a problem hiding this comment.
this internal hook should not be called from the outside of recordTable
I think we should expose the pre-injected state out of useRecordTable: const { selectedRowIdsScopeInjector } = useRecordTable(recordTableScopeId) that would internally do what you are doing here
| @@ -13,10 +13,10 @@ describe('groupActivitiesByMonth', () => { | |||
| expect(grouped[0].items).toHaveLength(1); | |||
| expect(grouped[1].items).toHaveLength(1); | |||
|
|
|||
| expect(grouped[0].year).toBe(2023); | |||
| expect(grouped[0].year).toBe(new Date().getFullYear()); | |||
| objectNamePlural, | ||
| createRecord, | ||
| }: { | ||
| recordTableId: string; |
There was a problem hiding this comment.
we should introduce RecordTableContainerProps
| objectNamePlural={objectNamePlural} | ||
| createRecord={handleAddButtonClick} | ||
| /> | ||
| </StyledTableContainer> | ||
| <RecordTableActionBar /> | ||
| <RecordTableContextMenu /> | ||
| <RecordTableActionBar recordTableId={recordTableId} /> |
There was a problem hiding this comment.
makes sense to pass recordTableId. I wonder if we should actually move RecordTableActionBar and ContextMenu within RecordTable itself (we can keep that for later refactoring)
There was a problem hiding this comment.
Yes, I was wondering the same thing
| tableFiltersScopeInjector, | ||
| tableSortsScopeInjector, | ||
| tableLastRowVisibleScopeInjector, | ||
| } = getRecordTableScopeInjector(); |
There was a problem hiding this comment.
getRecordTableScopeInjectors (I actually think that getRecordTableScopedStateGetter might be a better naming after all :p)
|
Looks good (Hover seems to be added to all cells) (Create View button is broken) |
For dropdown and record-table: