Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS Friends list is out of date #3192

Merged
merged 6 commits into from
Jan 3, 2024
Merged

OSS Friends list is out of date #3192

merged 6 commits into from
Jan 3, 2024

Conversation

gitstart-twenty
Copy link
Contributor

@gitstart-twenty gitstart-twenty commented Jan 2, 2024

Fixes #3181

gitstart-twenty and others added 4 commits January 2, 2024 04:37
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
@gitstart-twenty
Copy link
Contributor Author

gitstart-twenty commented Jan 3, 2024

Hello @FelixMalfait,

We're currently utilizing twenty-favicon for the icons here. However, we've noticed that some sites are still missing icons, and it could potentially be a bug in twenty-favicon. What do you think about opening an issue for this? Alternatively, should we consider using a different solution for the icons?

Screenshot 2024-01-03 at 12 24 02

cc @charlesBochet

@FelixMalfait
Copy link
Member

@gitstart-twenty Mmh indeed. Seems like there's an issue in the code. Feel free to assign that issue to yourself

@@ -0,0 +1,41 @@
'use client';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why there's not coloring by Github on that file? There's probably something wrong but I can't figure out what?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me. Haven't tried it locally yet. Does it behave well on mobile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me get you some screenshots @FelixMalfait

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some mobile screenshots

localhost_3000_oss-friends(iPhone 12 Pro)

localhost_3000_oss-friends(Pixel 7) (2)

localhost_3000_oss-friends(Pixel 7)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FelixMalfait I've not yet figured out why the syntax highlighting is not working for this particular file. The file has no visible errors

@gitstart-twenty
Copy link
Contributor Author

@gitstart-twenty Mmh indeed. Seems like there's an issue in the code. Feel free to assign that issue to yourself

Okay

gitstart-twenty and others added 2 commits January 3, 2024 19:06
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: niteshsingh1357 <niteshsingh1357@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thanks!

@FelixMalfait FelixMalfait merged commit 1924962 into main Jan 3, 2024
14 checks passed
@FelixMalfait FelixMalfait deleted the TWNTY-3181 branch January 3, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSS Friends list is out of date
3 participants