fixed button size #3194
Merged
fixed button size #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA
Hello there and welcome to our project! |
| width: 24px; | ||
| `; | ||
| const StyledBackIconButton = styled(IconButton)` | ||
| height: 24px; |
There was a problem hiding this comment.
this actually looks unnecessary if you pass the right size to the IconButton (small)
| @@ -54,14 +54,23 @@ const StyledTitleContainer = styled.div` | |||
| max-width: 50%; | |||
| `; | |||
|
|
|||
| const StyledBackIconButton = styled(IconButton)` | |||
| const StyledButtonDiv = styled.div` | |||
There was a problem hiding this comment.
I'm a bit confused why we would need a container here.
I'm taking a look!
charlesBochet
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2971
The width of the Title was set to 100% which I updated to adjust automatically with enabled and disabled back button. And set the size of buttons to 24px.