Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading more UI updated #3198

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Loading more UI updated #3198

merged 6 commits into from
Jan 5, 2024

Conversation

suman-somu
Copy link
Contributor

@suman-somu suman-somu commented Jan 2, 2024 •
edited

Fix #2498

Updated
image

lucasbordeau
lucasbordeau previously requested changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@lucasbordeau lucasbordeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution !

Could you please improve those parts :

Have the border-bottom match the figma design :
image

Keep the loading more row fixed when we scroll horizontally :
image

Put the styling in a StyledTD instead of in the style prop directly.

@suman-somu
Copy link
Contributor Author

suman-somu commented Jan 2, 2024 •
edited

changing

charlesBochet
charlesBochet reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have left comments!

packages/twenty-front/src/modules/object-record/record-table/components/RecordTableBody.tsx Outdated Show resolved Hide resolved
...y-front/src/modules/object-record/record-table/components/RecordTableBodyFetchMoreLoader.tsx Show resolved Hide resolved
...y-front/src/modules/object-record/record-table/components/RecordTableBodyFetchMoreLoader.tsx Outdated Show resolved Hide resolved
suman-somu and others added 3 commits January 4, 2024 08:44
@suman-somu
changes
a5d247b 
tbody added with ref
with margin and padding with theme variables
@charlesBochet
Merge branch 'main' into fix-2498
af74596
@charlesBochet
Remove unused react fragment
eb64d75
charlesBochet
charlesBochet approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@charlesBochet charlesBochet merged commit e50b62d into twentyhq:main Jan 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet approved these changes

@lucasbordeau lucasbordeau Awaiting requested review from lucasbordeau

Assignees
No one assigned
Labels
PR: awaiting author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style "loading more" rows on tables
3 participants
@suman-somu @charlesBochet @lucasbordeau