Fix docker install to have all projects #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesBochet
commented
Jan 2, 2024
| @@ -1,14 +1,6 @@ | |||
| FROM node:18.16-bullseye as twenty-dev | |||
|
|
|||
| WORKDIR /app | |||
| COPY ./package.json . | |||
There was a problem hiding this comment.
this is not useful as we don't yarn install anymore at build stage
| - ../../../packages/twenty-front:/app/packages/twenty-front | ||
| - ../../../packages/twenty-server:/app/packages/twenty-server | ||
| - ../../../packages/eslint-plugin-twenty:/app/packages/eslint-plugin-twenty | ||
| - ../../..:/app |
magrinj
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are updating the docker-compose dev configuration to share the whole root folder with Docker. This is simplifying the setup.
As an output, the dev docker image is 1.5GB and a volume is created for each node_module instance (so node_modules built in docker are not visible on the host file system).
I have also made a direct link to the IDE setup dock in the Docker setup doc to make sure contributors are also following it