Feat/activities custom objects #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasbordeau
commented
Jan 3, 2024
•
lucasbordeau
commented
- Created a useMultiObjectSearchSelectedItemsQuery hook to replace existing one with multi object querying
- Changed ActivityTargetInlineCellEditMode to accept any custom object
- Created a MultipleObjectRecordSelect component to handle multi object picking
packages/twenty-front/src/modules/ui/layout/selectable-list/components/SelectableItem.tsx
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Jan 5, 2024
| @@ -160,6 +163,7 @@ export const mockedActivities: Array<MockedActivity> = [ | |||
| id: '89bb825c-171e-4bcc-9cf7-43448d6fb278t', | |||
| createdAt: '2023-04-26T10:12:42.33625+00:00', | |||
| updatedAt: '2023-04-26T10:23:42.33625+00:00', | |||
| targetObjectNameSingular: 'person', | |||
There was a problem hiding this comment.
Does this actually come from the server?
| let relationAlias = fieldMetadata.isCustom | ||
| ? `${fieldKey}: ${fieldMetadata.targetColumnMap.value}` | ||
| ? `${fieldKey}: ${referencedObjectMetadata.targetTableName}` |
There was a problem hiding this comment.
not sure about this change, I'm facing bugs
There was a problem hiding this comment.
I'm facing bug even while putting it back actually.
What I'm doing:
- create a test object
- add a record
- go to that record and try to add an activity
There was a problem hiding this comment.
But I think this change should still be reverted and we should check the targetColumnMap value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.