Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3207 fix render self deploy #3221

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Jan 3, 2024

Close #3207

@charlesBochet charlesBochet temporarily deployed to 3207-fix-render-self-deploy - front-ec0n January 3, 2024 12:03 — with Render Inactive
Copy link

github-actions bot commented Jan 3, 2024

Warnings
⚠️

Changes were made to package.json, but not to yarn.lock - Perhaps you need to run yarn install?

Generated by 🚫 dangerJS against 0035a66

@charlesBochet charlesBochet temporarily deployed to 3207-fix-render-self-deploy - server-ec0n January 3, 2024 12:04 — with Render Inactive
@charlesBochet charlesBochet temporarily deployed to 3207-fix-render-self-deploy - front-ec0n January 3, 2024 12:11 — with Render Inactive
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment :)

@@ -23,6 +23,7 @@
"typeorm:migrate": "yarn typeorm migration:run -d ./src/database/typeorm/metadata/metadata.datasource.ts && yarn typeorm migration:run -d ./src/database/typeorm/core/core.datasource.ts",
"database:init": "yarn database:setup && yarn database:seed:dev",
"database:setup": "npx ts-node ./scripts/setup-db.ts && yarn database:migrate",
"database:setup:prod": "npx ts-node ./scripts/setup-db.ts && yarn typeorm:migrate",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you also seed in this one?

Copy link
Contributor Author

@martmull martmull Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we said we should not seed. Seeds are run when a workspace is created so we don't need them here i beleive

@martmull martmull marked this pull request as ready for review January 3, 2024 13:22
@charlesBochet charlesBochet merged commit ea06f04 into main Jan 3, 2024
14 of 15 checks passed
@charlesBochet charlesBochet deleted the 3207-fix-render-self-deploy branch January 3, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Render self deploy
2 participants