Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Event core object #3232

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix Event core object #3232

merged 1 commit into from
Jan 4, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Jan 4, 2024

Context

We have a few objects that are not standard objects which means they are not part of the metadata tables (such as user, workspace, refreshToken, etc). However, those objects are defined in the code in their own resolvers and exposed in the same graphql schema shared with standard and custom objects.

Implementation

ex: "Event" custom object can be created which breaks the generation of the graphql schema because we already defined a createEvent in our analytic resolver.

Because of that, we have introduced a check in the createObject endpoint to reject some names. This PR adds some missing objects that have their own resolvers and could conflict with custom objects

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job

@Weiko Weiko merged commit 4fddafc into main Jan 4, 2024
14 checks passed
@Weiko Weiko deleted the c-fix-event-core-object branch January 4, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants