Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trimming email input in validation #3195 #3246

Merged
merged 1 commit into from
Jan 5, 2024
Merged

trimming email input in validation #3195 #3246

merged 1 commit into from
Jan 5, 2024

Conversation

Rakan-Makhashin
Copy link
Contributor

trimming email input value for the validation process

Copy link

github-actions bot commented Jan 5, 2024

CLA

Hello there and welcome to our project!
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.
Although we don't have a dedicated legal counsel, having this kind of agreement can protect us from potential legal issues or patent trolls.
Thank you for your understanding.

Generated by 🚫 dangerJS against 7900a98

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Rakan-Makhashin.
Could you also take care of the user existence check? Right now, if I type: "tim@apple.dev " / "AppleCar2025" in the sign-in form, it is trying to sign me up has it thinks "tim@apple.dev " <> "tim@apple.dev"

This can be handled in a separate PR though :)

@charlesBochet charlesBochet merged commit db17d46 into twentyhq:main Jan 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants