Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Relation field card feature flag #3311

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

thaisguigon
Copy link
Contributor

@thaisguigon thaisguigon commented Jan 8, 2024

Related to #3123

@thaisguigon thaisguigon marked this pull request as ready for review January 8, 2024 16:51
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thaisguigon We should use featureFlag here! This will ease a lot the activation/deactivation of the feature and enable to do it per workspace
See IS_RELATION_FIELD_TYPE_ENABLED for example

@thaisguigon thaisguigon force-pushed the feat/relation-field-card-feature-flag branch from 839a06a to 8a1e419 Compare January 9, 2024 10:29
@thaisguigon
Copy link
Contributor Author

@thaisguigon We should use featureFlag here! This will ease a lot the activation/deactivation of the feature and enable to do it per workspace See IS_RELATION_FIELD_TYPE_ENABLED for example

Done!

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charlesBochet charlesBochet merged commit 0b50528 into main Jan 9, 2024
12 of 14 checks passed
@charlesBochet charlesBochet deleted the feat/relation-field-card-feature-flag branch January 9, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants