3242 all message recipients should be stored #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weiko
reviewed
Jan 9, 2024
| ): AddressObject[] { | ||
| if (!addressObject) return []; | ||
|
|
||
| if (!Array.isArray(addressObject)) { |
There was a problem hiding this comment.
nit:
Suggested change
| if (!Array.isArray(addressObject)) { | |
| return Array.isArray(addressObject) ? addressObject : [addressObject]; | |
| [fromHandle], | ||
| ); | ||
|
|
||
| const workspaceMemberId = workspaceMember[0]?.accountOwnerId; |
There was a problem hiding this comment.
Suggested change
| const workspaceMemberId = workspaceMember[0]?.accountOwnerId; | |
| const workspaceMemberId = workspaceMember[0]?.id; |
I think you meant this?
| [recipient.address], | ||
| ); | ||
|
|
||
| const recipientWorkspaceMemberId = workspaceMember[0]?.accountOwnerId; |
There was a problem hiding this comment.
Same here, probably
Suggested change
| const recipientWorkspaceMemberId = workspaceMember[0]?.accountOwnerId; | |
| const recipientWorkspaceMemberId = workspaceMember[0]?.id; |
Weiko
reviewed
Jan 9, 2024
|
|
||
| const recipientWorkspaceMemberId = workspaceMember[0]?.accountOwnerId; | ||
|
|
||
| await manager.query( |
There was a problem hiding this comment.
nit: pgql should handle bulk insert
Weiko
reviewed
Jan 9, 2024
| ], | ||
| ); | ||
|
|
||
| await this.saveMessageRecipients( |
There was a problem hiding this comment.
nit: We could probably mutualise this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3242