New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Select #3327

Merged

lucasbordeau merged 1 commit into main from fix-select

Jan 9, 2024

Member

charlesBochet commented Jan 9, 2024

While working on Implement select v1 #3312, I have introduced a bug on Settings page. I'm fixing it in this PR.
I'm also fixing an issue with CommandMenu hotkeyScopes: even when the Command Menu was not opened, the goBackToPreviousHotkeyScope() was triggered on click in the app, leading to weird bugs on Settings page


          Fix Select

5891f1e

lucasbordeau approved these changes

View reviewed changes

lucasbordeau merged commit 47ac97d into main

11 of 13 checks passed

lucasbordeau deleted the fix-select branch

January 9, 2024 13:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment